Keep Linux updates within startup health deadline - #34
Merged
Conversation
Signed-off-by: Joseph Yaksich <gitcommit90@users.noreply.github.com>
📝 WalkthroughWalkthroughThe release is bumped to 0.0.25, including channel-machine image defaults and documentation. Server bootstrap now prepares durable memory asynchronously so health-port readiness does not wait for optional memory installation. ChangesRelease and runtime updates
Estimated code review effort: 2 (Simple) | ~10 minutes Sequence Diagram(s)sequenceDiagram
participant bootstrap
participant memoryRuntime
participant HTTPServer
bootstrap->>memoryRuntime: Start durable-memory preparation
bootstrap->>HTTPServer: Open health port
memoryRuntime-->>bootstrap: Resolve or reject asynchronously
bootstrap->>bootstrap: Handle preparation errors
Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@CHANGELOG.md`:
- Around line 767-768: Remove the stale [0.0.24] compare-link entry from the
changelog, or update it to reference a valid published tag; keep the existing
[Unreleased] and [0.0.25] links unchanged.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: b6ec0c31-0699-4da0-a026-5218429bdfda
⛔ Files ignored due to path filters (1)
package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (8)
CHANGELOG.mdREADME.mdpackage.jsonsrc/server/channel-computers.tssrc/server/db.tssrc/server/index.tstest/channel-computers.mjstest/desktop.mjs
Comment on lines
+767
to
+768
| [Unreleased]: https://github.com/gitcommit90/1Helm/compare/v0.0.25...HEAD | ||
| [0.0.25]: https://github.com/gitcommit90/1Helm/compare/v0.0.23...v0.0.25 |
There was a problem hiding this comment.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
Remove the stale 0.0.24 compare link.
The release notes state that 0.0.24 was never tagged or published, but [0.0.24] still points to that nonexistent tag on Line 769. Remove the reference or point it to a valid published target.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@CHANGELOG.md` around lines 767 - 768, Remove the stale [0.0.24] compare-link
entry from the changelog, or update it to reference a valid published tag; keep
the existing [Unreleased] and [0.0.25] links unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Result\n\nRetained Linux hosts now open the health port without synchronously initializing every resident memory database, so real systemd updates stay within their bounded health window. Memory remains initialized for newly created agents and lazily on memory operations.\n\nThis advances the unpublished 0.0.24 candidate to 0.0.25 and retains all Linux/Windows terminal-runtime corrections merged in #33.\n\n## Verification\n\n- npm run typecheck\n- npm run build\n- npm test: 125 native assertions + 110 runnable Node/browser contracts passed; 2 environment-only skips\n- npm run test:onboarding-browser: 20 passed\n- git diff --check
Summary by CodeRabbit